Document eUICC operation codes - #545
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the XML documentation for Android.Telephony.Euicc.Operation to replace placeholder text with meaningful descriptions of eUICC operation categories as used in EuiccManager detailed error codes.
Changes:
- Added a type-level summary/remarks explaining how operation categories map into the detailed error code structure.
- Added per-enum-member summaries (and reference links) for all 11
Operationvalues.
Suppressed comments (11)
docs/xml/Android.Telephony.Euicc/Operation.xml:55
- The member remarks blocks link to Android reference docs but don’t include the standard AOSP/CC BY 2.5 attribution paragraph that other Android.Telephony.Euicc members include. Please add it here (and similarly for the other members in this enum).
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_APDU" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_APDU</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:90
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph that’s present across other Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_DOWNLOAD" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_DOWNLOAD</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:125
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_EUICC_CARD" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_EUICC_CARD</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:160
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_EUICC_GSMA" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_EUICC_GSMA</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:195
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_HTTP" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_HTTP</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:230
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_METADATA" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_METADATA</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:265
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_SIM_SLOT" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_SIM_SLOT</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:300
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_SMDX" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_SMDX</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:335
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_SMDX_SUBJECT_REASON_CODE" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_SMDX_SUBJECT_REASON_CODE</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:370
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_SWITCH" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_SWITCH</code>.</a>
</format>
docs/xml/Android.Telephony.Euicc/Operation.xml:405
- This remarks block is missing the standard AOSP/CC BY 2.5 attribution paragraph used throughout Android.Telephony.Euicc docs. Add it for consistency and licensing attribution.
<remarks>
<para>
<format type="text/html">
<a href="https://developer.android.com/reference/android/telephony/euicc/EuiccManager#OPERATION_SYSTEM" title="Reference documentation">Java documentation for <code>android.telephony.euicc.EuiccManager.OPERATION_SYSTEM</code>.</a>
</format>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
The source XML contains the requested attribution, but ECMA2Yaml ignores <remarks> on enum fields, so all 11 member-specific reference links and notices are discarded from generated documentation. Please move the member links into publishing-supported content (for example, type-level remarks) and verify the exact generated preview no longer reports the scoped enum-remarks loss: Operation.xml.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Addressed in aa29be0: moved all 11 |
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
The eleven operation references and attribution now live in publishing-supported type-level content and render correctly in the generated documentation.
Summary
Android.Telephony.Euicc.Operationvalues and their detailed-error-code role.Sources
Validation
docs/xml/Android.Telephony.Euicc/Operation.xmlas XML.To be added.placeholders in the scoped file (13 removed).git diff --check.